Loris
Loris copied to clipboard
aces
[Schedule Module] add new schedule module into Loris
Brief summary of changes
Rewrite this module from IBIS.
Testing instructions
Test plan
The schedule permission does not show up on the user accounts module. I am also able to add, edit, and delete an appointment without having the permission.
From the admin account or from an account with the scheduling permission, I am not able to add an appointment. When I click on "Add appointment", it brings me to this blank page:
@CamilleBeau You need to run the SQL/New_patches/2020-03-03-schedule_module.sql patch "
INSERT INTO user_perm_rel(UserID,PermID) VALUES (
(SELECT ID FROM users WHERE UserID='admin'),
(SELECT permID FROM permissions WHERE code='schedule_module')
);
" in this PR.
Have you run "sudo make " to compile react?
I have tested it. It works well.
@kongtiaowang Strange, I am still getting the same error of a blank page after clicking "Add appointment." Maybe we should have another reviewer check to see if it is working for them
@CamilleBeau Could you test it again? I have fixed the can't load issue after rebasing to new main branch.
Looks good. I only found two issues:
- Can not order by "Data Entry Status" properly
- When deleting an appointment, I am brought to the same blank page I referenced earlier (attached) instead of back to the appointment results.
@CamilleBeau Could you show me more detail on the console? I can't reproduce the issuse you found. Maybe before you run make, you need to run "git pull aces main" to rebase this branch.
@CamilleBeau Could you show me more detail on the console? I can't reproduce the issuse you found. Maybe before you run make, you need to run "git pull aces main" to rebase this branch.
@kongtiaowang Yes no longer getting the issue.
@ridz1208 @driusan I think this PR is ready to merge. It is better to go into 24.0-release.
Just manually tested, everything looks good but the module is only accessible if the user has permission "Schedule Module: edit and delete the appointment". Is this intended? Or is the user supposed to be able to view the module (but not edit/delete appointments) without this permission?
@CamilleBeau For the premission, it is intended base on IBIS and test plan.
@kongtiaowang can you fix the tests please ?
@CamilleBeau can you re-add the approve and pass manual test flag if its tested please
@kongtiaowang should CandID be used when it's referenced in LORIS as DCCID?
Also might want to swap the table column order for PSCID being shown first and then DCCID after like how the candidate_list module has as order for consistency.
Hi @kongtiaowang, a few browser console errors:
Warning: Failed prop type: Invalid prop `minYear` of type `number` supplied to `DateElement`, expected `string`.
Warning: Failed prop type: Invalid prop `value` supplied to `SelectElement`.
Warning: Failed prop type: Invalid prop `columns` of type `string` supplied to `Filter`, expected `number`.
Warning: Failed prop type: Invalid prop `value` of type `boolean` supplied to `TextboxElement`, expected `string`.
Warning: Failed prop type: Invalid prop `value` of type `boolean` supplied to `DateElement`, expected `string`.
Warning: Failed prop type: Invalid prop `value` of type `boolean` supplied to `TimeElement`, expected `string`.
Warning: Failed prop type: Invalid prop `columns` of type `string` supplied to `FieldsetElement`, expected `number`.
Hi @kongtiaowang, when a new appointment has been created, the user has to hard refresh the module after the success dialogue for seeing the new appointment in the table. I think it should be an automatic refresh or by having the new appointment details be added to the table. The delete appointment functionality seems to remove from the table without needing to refresh the module.
All the issues will be fixed after rebase to origin/main. I think this PR is ready.