Loris icon indicating copy to clipboard operation
Loris copied to clipboard

Move server configuration settings from the database to the config.xml file

Open johnsaigle opened this issue 5 years ago • 5 comments

There are certain configuration settings that will break LORIS when changed, e.g. base, and url. They shouldn't be editable from the front-end.

The decision was made in a recent meeting to move these fields to the config.xml file instead of the database. This has the result of overriding anything the user enters in the front-end thus fixing the issue of someone accidentally breaking LORIS.

This will also allow developers to edit fields via the configuration file rather than establishing a connection to the database.

There are likely other fields (host?) that should also be moved to the config.xml file.

Further discussion is required as to whether e.g. file upload paths should be moved too.

johnsaigle avatar Nov 12 '19 16:11 johnsaigle

Tagging @ridz1208 @christinerogers and @driusan to help move the discussion along

johnsaigle avatar Nov 12 '19 16:11 johnsaigle

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 11 '20 17:01 stale[bot]

Not sure if we keep this alive or make individual issues for each parameter

ridz1208 avatar Jan 11 '20 20:01 ridz1208

The Stale label is being removed automatically because some activity has occurred or because the developers have decided that this pull request is important and should not continue to be overlooked.

stale[bot] avatar Jan 11 '20 20:01 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 11 '20 20:03 stale[bot]