Loris icon indicating copy to clipboard operation
Loris copied to clipboard

[SQL]Incorrect login_summary_statistics table name in LORIS 27 SQL patch - 27.0-release

Open kongtiaowang opened this issue 2 months ago • 3 comments

Incorrect login_summary_statistics table name in LORIS 27 SQL patch #10095

kongtiaowang avatar Nov 07 '25 15:11 kongtiaowang

Not sure why you changed the table name to Login_Summary_Statistics (uppercase), I had approved the PR, and the lowercase version is more consistent with the LORIS SQL schema.

If you needed a merge after review, just tag Dave here or on Slack IMO.

MaximeBICMTL avatar Nov 25 '25 03:11 MaximeBICMTL

@MaximeBICMTL During last week's meeting, Dave suggested adopting a more reasonable approach to changing capitalized table names in this PR.

kongtiaowang avatar Dec 01 '25 14:12 kongtiaowang

Not sure I agree with Dave here (we discussed briefly in PM) but as long as it works it's fine with me.

MaximeBICMTL avatar Dec 02 '25 03:12 MaximeBICMTL