docker-reforger
docker-reforger copied to clipboard
Add parameters for basic handling of mods
LGTM but I don't know Python so leaving the approval to someone else 😁
Could allow JSON and the IDs in the env, load the json first then append from env
Sounds good, will do
Name is only for human readability and not used by the server.
I suggest to use only one environment variable to specify mods, GAME_MODS, which accepts either any version or specific version.
- Mods with any versions,
GAME_MODS=5965770215E93269,59664C0CB36501CD - Mods with specific versions,
GAME_MODS=5965770215E93269=1.0.6,59664C0CB36501CD=0.3.0 - Mods with any and specific versions,
GAME_MODS=5965770215E93269,59664C0CB36501CD=0.3.0
Workshop should use a volume to avoid redownload when container is recreated, for example VOLUME /reforger/workshop
To use the volume and separate workshop folder start the game with argument -addonDownloadDir /reforger/workshop
While I do agree with an option for specifying mod version in the GAME_MODS_IDS_LIST, and keeping them on a dedicated volume, I don't think removing an option to provide mods via a file is a good idea tbh. Managing dozens of mods only via one long ENV would be quite a pain. Also it allows potential outside mod managers to just generate file instead of compiling a long ENV string. Your call tho
Would be good with an example environment variable in README for how to load mods. The Dockefile has no example so one has to read through the launch.py code.
@Dahlgren re-review please.
Lint failed though, I will take a look in an hr or two 👀