ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Towing - Fix some issues

Open Dystopian opened this issue 3 years ago • 2 comments

When merged this pull request will:

  • add multiple towing;
  • add JIP compatibility;
  • add towing to ships and helicopters;
  • add hook also to parent;
  • replace hook model with invisible one;
  • fix immediate rope attachment when click Attach tow rope menu if player is close to vehicle;
  • fix MP issue when rope looks detached on other clients;
  • fix MP issue when you attach rope to non-local vehicle;
  • fix MP issue when one player attaches vehicles and other player tows;
  • fix MP issue when "tow" client is disconnected and rope is broken.

Multiple towing means either several ropes between parent and child or one parent with several children one by one and parallel.

setTowParent is not JIP compatible so I added workaround.

It turned out that ships can tow and can be towed, helicopters can be towed as well (at least those with wheels).

With parent hook rope can be detached from parent too.

Current hook model glows very much. This can be a problem at night when you want to hide vehicles. I didn't find more suitable model and used empty one which is OK. There is \A3\Data_f\Hook\Hook_F.p3d which is good but it could be weird for many vehicles.

ropeAttachTo and ropeDetach commands must be run where parent and rope are local. setTowParent must be run on all clients. Current implementation runs Deleted and RopeBreak EHs on client where rope was attached. When client disconnects EHs aren't triggered.

Dystopian avatar Aug 21 '22 08:08 Dystopian

Ready for review.

I didn't find a way to fix possible rope attachment inside vehicles resulting impossible to detach it. I added parent hook as partial workaround but if anybody knows a better way to fix please tell me.

Dystopian avatar Aug 29 '22 01:08 Dystopian

After #8963 and this PR rope can also be added to boats inventory. I can't really decide if it's needed.

Dystopian avatar Aug 29 '22 15:08 Dystopian

To fix possible rope attachment inside vehicles resulting impossible to detach it I added Detach actions on each towing/towed vehicle.

I tested towing helicopters with enabled AFM and it works OK as with disabled one. But I disabled towed helicopters because I don't think helicopters have suitable towing points (except landing gear maybe). Naturally this can be discussed.

I added rope to boats inventory because it looks quite appropriate.

Dystopian avatar Nov 05 '22 20:11 Dystopian

Whats the status on this? We had several Issues in our last OP that would probably all be fixed with this PR.

Andx667 avatar Oct 25 '23 08:10 Andx667

Whats the status on this?

This PR is quite large and should be tested well by ACE devs. So we have to wait with patience.

Dystopian avatar Oct 25 '23 12:10 Dystopian

Also hoping to see this PR go through. Towing is completely inop in both singleplayer and multiplayer in 3.16

matthawkins2 avatar Feb 04 '24 19:02 matthawkins2

🍌

LinkIsGrim avatar Feb 05 '24 18:02 LinkIsGrim