ACE3
ACE3 copied to clipboard
acemod
Medical Treatment - Change stitching when wound reopening disabled
When merged this pull request will:
- Allow stitching when "Clear Trauma" is set to "On Stitch".
- This changes behaviour as such that trauma is cleared upon finishing stitching, instead of periodically, with time calculation based on
ΣbodyPartDamage * GVAR(woundStitchTime). This is due to some of the values otherwise used for stitching are only available when wound reopening is enabled.
IMPORTANT
- [x] If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- [x] Development Guidelines are read, understood and applied.
- [x] Title of this PR uses our standard template
Component - Add|Fix|Improve|Change|Make|Remove {changes}.
I think in terms of end user experience this isn't the ideal solution (since if action is interrupted that progress will be lost). However, it does identify a valid case that's not being handled and seems fine as an initial solution.
Having recently reacquainted myself with our stitching code to produce #8926, the way we handle stitching logic is not very intuitive and seems over complicated. I reckon if someone was motivated they could refactor the underlying system in a way which also accommodates this case with incremental progress.
I think in terms of end user experience this isn't the ideal solution (since if action is interrupted that progress will be lost). However, it does identify a valid case that's not being handled and seems fine as an initial solution.
Having recently reacquainted myself with our stitching code to produce #8926, the way we handle stitching logic is not very intuitive and seems over complicated. I reckon if someone was motivated they could refactor the underlying system in a way which also accommodates this case with incremental progress.
This was essentially my thought on it as well, a stopgap solution until someone who is more acquainted with ACE produces something better.