ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Repair - Add wheel patching

Open BrettMayson opened this issue 2 years ago • 3 comments

When merged this pull request will:

  • Adds the ability to patch wheels

IMPORTANT

  • [X] If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • [X] Development Guidelines are read, understood and applied.
  • [X] Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

BrettMayson avatar Mar 05 '22 22:03 BrettMayson

Are you adding an Item like a tire patch or just magic tire patching? https://shop.myerstiresupply.com/ERP2Web49/e2wShoppingCatalog.aspx?parentId=3100012149&parentLink=2100001027:3100012148:3100012149

killerswin2 avatar Mar 08 '22 05:03 killerswin2

Also you can't patch run flat tires, there are very few conditions that a run flat can be patched. The hunter MATV is run flat.

killerswin2 avatar Mar 08 '22 05:03 killerswin2

@killerswin2 It was intended to be a quick quality of life improvement, it could be disabled by default or someone else can add more conditions if they'd like, but the state of this PR right now is all I intended to implement

BrettMayson avatar Apr 10 '22 22:04 BrettMayson

https://github.com/acemod/ACE3/commit/9c2c3ac0d3c75c65bbd2900f766f181f5882cbb5 - icon ok? 20230222140654_1

PabstMirror avatar Feb 22 '23 20:02 PabstMirror

Looks good to me

BrettMayson avatar Feb 23 '23 04:02 BrettMayson