ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Speed and Altitude units

Open BrettMayson opened this issue 5 years ago • 14 comments

When merged this pull request will:

  • Add additional speed units

    • km/h
    • mph
    • kn
    • m/s
  • Add additional altitude units

    • meters (m)
    • feet (f)
  • Display altitude to 1 decimal place below 10

BrettMayson avatar Jun 08 '19 20:06 BrettMayson

Is this worth it to have two (or more) PFH running each frame? Can this be optimized to have no PFH running in case the settings match Arma default units?

commy2 avatar Jun 09 '19 07:06 commy2

It could be modified to use no PFH at the cost of complication. When in a land vehicle there will be a single PFH running, in aircraft there will be 2.

BrettMayson avatar Jun 09 '19 07:06 BrettMayson

Is the control actually deleted when leaving the vehicle, therefore is there the PFH only running when inside the vehicle and it stops when leaving the vehicle?

commy2 avatar Jun 09 '19 08:06 commy2

Is the control actually deleted when leaving the vehicle, therefore is there the PFH only running when inside the vehicle and it stops when leaving the vehicle?

Yes, when entering the vehicle the PFHs are created, 1 for land and 2 for air. Upon exiting the controls are destroyed and the PHFs and EHs are removed

BrettMayson avatar Jun 09 '19 09:06 BrettMayson

Was this confirmed in a test? It might be that the controls linger and are just hidden, but still exist, until a new vehicle is entered.

commy2 avatar Jun 09 '19 09:06 commy2

It was confirmed with systemChat :D

The controls were null upon leaving a vehicle and the PFHs are being removed without issue.

BrettMayson avatar Jun 09 '19 09:06 BrettMayson

I think units component name is too similar to units arma word as men. Maybe it should be more descriptive.

Dystopian avatar Jun 10 '19 07:06 Dystopian

Probably be moved to the ui component.

commy2 avatar Jun 10 '19 09:06 commy2

I didn't put it in the UI addon since in my opinion, it is serving a different purpose. It is possible someone wouldn't want the config changes made to the UI but still want the different units this addon provides. I do agree that units isn't the best name but it's all I could come up with at the time.

BrettMayson avatar Jun 12 '19 04:06 BrettMayson

@commy2 Ready for a re-review

BrettMayson avatar Jul 08 '19 13:07 BrettMayson

Since this modifies the altitude display already, would it be possible to have both ASL and AGL measurements shown at the same time in all aircraft? This was a feature back in ACE2 (along with a UI variometer), random pic showing this: https://i.ytimg.com/vi/oLnRu10thKY/maxresdefault.jpg (ASL middle right)

Max255PL avatar Jul 15 '19 22:07 Max255PL

Found a bug with this, when controlling UAVs the UI is still getting the player position instead of the drone. Result as expected.

Max255PL avatar Aug 20 '19 11:08 Max255PL

All vehicle ACE_player should be cameraOn.

commy2 avatar Aug 20 '19 12:08 commy2

Since this modifies the altitude display already, would it be possible to have both ASL and AGL measurements shown at the same time in all aircraft? This was a feature back in ACE2 (along with a UI variometer)

This PR is not really modifying the UI, and there is unfortunately not enough space to add these in. It's something I'd be interested in adding but it might be better suited for an aircraft orientated mod like AWEsome since it will require modifying the look of the UI to add room. At the very least it should be a different PR if it is to be added to ACE.

BrettMayson avatar Aug 21 '19 03:08 BrettMayson