ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Logistics enable/disable settings (no more compat 🎉)

Open BaerMitUmlaut opened this issue 6 years ago • 4 comments

When merged this pull request will:

  • Add enable settings for each component
  • Remove the need for compat addons for the logistic components

Status:

  • [x] Refuel
  • [x] Repair
  • [ ] Rearm

BaerMitUmlaut avatar Jun 07 '19 23:06 BaerMitUmlaut

addons/repair/.vscode/ipch/1ce1e1282607b219/mmap_address.bin

burp Maybe we should add .vscode to repository .gitignore?

dedmen avatar Jun 11 '19 10:06 dedmen

If something does setUnitTrait it'll override, but IMO this is better than replacing every toolkit.

I'd rather defer the refuel/rearm compats to another PR, they'll need lots more special handling from the looks of it.

LinkIsGrim avatar Jul 14 '23 20:07 LinkIsGrim

but IMO this is better than replacing every toolkit

Why? We have a framework for item replacement already and it stays compatible with the vanilla attributes. This is a regression.

BaerMitUmlaut avatar Jul 18 '23 08:07 BaerMitUmlaut

I'd like to avoid item replacement because of custom toolkits. I'm aware item types can be replaced directly, but what about those custom toolkits' mass, item description, or whatever other custom properties? Or any other mod/mission checking for toolkit items by type, or for the item itself?

LinkIsGrim avatar Jul 18 '23 19:07 LinkIsGrim

Succeeded by other PRs.

LinkIsGrim avatar Apr 07 '24 01:04 LinkIsGrim