ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Common - Configs cleanup and UI improvements

Open mharis001 opened this issue 7 years ago • 4 comments

When merged this pull request will:

  • Allow progress bar to be fully repositioned with the ingame layout tool (remove old setting for just top or bottom)
    • Preview: ace_progress_position
  • Added setting to make progress bar change color based on completion
  • Update/cleanup displayTextStructured with macros and remove unnecessary code
  • Cleanup configs, mainly UI ones (move away from old define.hpp base classes and use built in Arma ones)
  • Use common grid/color macros and rename files (not sure what happened with git mv😞)
  • Add stringtable entries for CfgUIGrids entries
  • Depreciate addMapMarkerCreatedEventHandler and removeMapMarkerCreatedEventHandler in favor of CBA_fnc_addMarkerEventHandler and CBA_fnc_removeMarkerEventHandler

mharis001 avatar Jun 17 '18 04:06 mharis001

The ACE progress bar should be replaced with CBA_fnc_progressBar. The ACE function should remain and add the canInteractWith condition in form of a wrapper. The CBA progress bar already can be moved and resized by this menu.

https://github.com/CBATeam/CBA_A3/blob/master/addons/ui/fnc_progressBar.sqf

commy2 avatar Jun 18 '18 16:06 commy2

Not sure what the best method for wrapping the condition would be. Can't just put the local variable in a code block and compile + format seems like a bad solution.

mharis001 avatar Jun 21 '18 21:06 mharis001

Store condition as code in fnc_progressBar arguments and just call it? Make it the last parameter in arguments to not throw the user off if he has his own arguments.

dedmen avatar Jun 22 '18 07:06 dedmen

Why don't we just use the cba UI elements, but keep our function.

PabstMirror avatar Jun 22 '18 20:06 PabstMirror

Closing due to age and/or inactivity, unlikely to be finished or has to be reworked due to other changes over the years. May be re-opened if someone finds it useful, even better just open a new up-to-date PR.

Mike-MF avatar Sep 11 '23 00:09 Mike-MF

@LinkIsGrim

LinkIsGrim avatar Sep 11 '23 00:09 LinkIsGrim