ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Wardrobe - New Addon - System to modify wearables

Open OverlordZorn opened this issue 1 year ago • 10 comments

When merged this pull request will:

  • New Addon: Wardrobe Introduces a new system to modify currently worn gear.

For Example:

  • Roll up/down your sleeves.
  • Raise or lower the visor of helmets.
  • Modify turbans from to the other variants.
  • Combat Goggles <-> Balaclava with Combat Goggles <-> Balaclava

UX:

  • ACE Self Interaction -> Equipment -> Wardrobe (if modifiable Item)
  • ~~Inventory -> CBA Context Menu on Wearable Slot~~
    • Moved into seperate PR

Compats for: GM, SOG, WS, RF

ToDo once approved:

  • remove test mission from PR

IMPORTANT

  • [x] Requires https://github.com/CBATeam/CBA_A3/pull/1751
  • [x] Requires https://github.com/CBATeam/CBA_A3/pull/1758

Related PR's

  • Extended By #10911
  • Extended By #10912
  • Extended By #10913
  • Extended By #10914
  • Extended By #10905

OverlordZorn avatar Dec 27 '24 01:12 OverlordZorn

Core Features are complete.

OverlordZorn avatar Jan 02 '25 13:01 OverlordZorn

all the things with zrn tags need to be changed

Drofseh avatar Jan 02 '25 20:01 Drofseh

Haven't tested nor looked at code yet. How are inherited config properties handled?

LinkIsGrim avatar Jan 03 '25 09:01 LinkIsGrim

Haven't tested nor looked at code yet. How are inherited config properties handled?

Wearables with fully inherited subclass are ignored.

OverlordZorn avatar Jan 03 '25 10:01 OverlordZorn

Wearables with fully inherited subclass are ignored.

Alright, should be safe then. That should also go in documentation.

LinkIsGrim avatar Jan 03 '25 10:01 LinkIsGrim

Big undertaking, and a bit of a nitpick, but I feel like this'd be more maintainable if wardrobe entries were kept in a CfgWardrobe root entry:

class ADDON {
    class Uniforms {
        class uniform_classname {
            ...
        };
    };
    class Glasses {
         ...
    };
};

Don't have to worry about inheritance, and easier for other components to hook into. Child classes could be a problem, though, but I don't think we'd want child classes to inherit their parent's variants anyway.

LinkIsGrim avatar Feb 05 '25 02:02 LinkIsGrim

Requires https://github.com/CBATeam/CBA_A3/pull/1751

OverlordZorn avatar Apr 27 '25 15:04 OverlordZorn

self reminder

LinkIsGrim avatar May 02 '25 20:05 LinkIsGrim

Also missmatch should be spelt mismatch.

https://github.com/acemod/ACE3/pull/10606/commits/f908a7a9c5dee92647742a5904d948b2ce7caaa2 done

OverlordZorn avatar May 05 '25 23:05 OverlordZorn

  • [x] snake_case -> camelCase
  • [x] "404" -> nil
  • [x] import_baseClasses -> macro
  • [x] EOF
  • [x] Move debug fnc to dev

OverlordZorn avatar May 13 '25 11:05 OverlordZorn

"5 requested changes" i dont find those. ether they are already resolved or the code doesnt exist anymore but github still shows them as outstanding.

OverlordZorn avatar Jun 21 '25 08:06 OverlordZorn

I haven't really touched the replace functions and the stuff that touches intel items / spare barrels, but I'm through with my cleanup otherwise.

BaerMitUmlaut avatar Jul 27 '25 21:07 BaerMitUmlaut

yea idk why but shits broke now.

  • Uniforms cant switch from Sleeves Up to Sleeves Down (no component required, still cant do it).
  • Balaclava can be changed from normal to the goggled version without the component required being present in the inventory. Once switched to goggled version, the action to simple take it off is not availble. I assume the action condition check got flipped around.

OverlordZorn avatar Jul 28 '25 14:07 OverlordZorn

I was able to fix the before mentioned changes, but now it duplicates items, which it didnt do before

OverlordZorn avatar Jul 28 '25 15:07 OverlordZorn

it fixed now, seems i misinterpretated a change in my quest of finding the first issue.

OverlordZorn avatar Jul 28 '25 16:07 OverlordZorn

Do we keep hemtt launch parameters? What about the mission?

I dont know what the ace standard is but i would like to keep it because it makes working on compats more convinient as its already a somewhat labour intensive process

OverlordZorn avatar Sep 26 '25 21:09 OverlordZorn

Launch parameters can be kept IMO. Would be better if we could skip distributing the mission in CI but I don't think it's a big deal. Maybe move to ./extras like the Adv. Ballistics missions.

LinkIsGrim avatar Sep 30 '25 01:09 LinkIsGrim

Launch parameters can be kept IMO. Would be better if we could skip distributing the mission in CI but I don't think it's a big deal. Maybe move to ./extras like the Adv. Ballistics missions.

We don't ship the .hemtt folder, so they aren't being published

BrettMayson avatar Sep 30 '25 18:09 BrettMayson

@Andx667 😭🥳

OverlordZorn avatar Oct 04 '25 11:10 OverlordZorn