acemod
Medical - Add Additional Hitpoints to the medical system
When merged this pull request will:
- Adds 6 new hitpoints to the ace medical system (Neck, Chest, and four upper limbs) for better compatibility and modularity to other medical mods
ToDo -GUI
IMPORTANT
- If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Development Guidelines are read, understood and applied.
- Title of this PR uses our standard template
Component - Add|Fix|Improve|Change|Make|Remove {changes}.
If the upper limbs are called upper the lower limbs should be called lower. Upper Arm and Arm sounds weird compared to Upper Arm and Lower Arm.
I don't hate this on principle but oh dear this can break in so many ways (both itself and BWC)
I don't hate this on principle but oh dear this can break in so many ways (both itself and BWC)
I know, its horrible for BWC, but its a very much needed update as KAM needs more granularity in terms of hitpoints (and overwrites are not great
I had a differing path as well, but that would have had me make hitpoints for everything, down to the granularity of individual hands and joints, which would have been worse
Some other considerations: Do you bleed twice as much for explosions now? (I have a feeling you do),
Yes, but there is another PR in the pipe that reworks wounds and their creation, so in the end it will be equivalent to how it was before
Is sway just twice as strong on the worst case too?
Yes, and I'm looking at making a change to that
Current issues ~~GUI, i need to do it~~ Done
Explosions are kinda weird for damage, likes to leave parts of limbs untouched, might need the damage randomizer to be a flip flop instead, unless its all one EH and if so ill need to work at explosive damage
~~End key is broken, somehow, no idea where or how~~ (it was a keybind issue)
~~Chest and torso can be fractured, to be fixed~~ (its fixed, didn't change a number)
Current issue, explosions are one call of woundshandlerbase per hitpoint, and splitting it isn't fruitful,
I'll review when I have time, which isn't going to be soon. I maintain that this is a hell of a change to how the system has worked for years and I'm not a fan personally.