ACE3 icon indicating copy to clipboard operation
ACE3 copied to clipboard

Frag - Implement Arma v2.18 changes from #10157

Open lambdatiger opened this issue 1 year ago • 7 comments

This PR requires #10157 to be merged. When merged this pull request will:

  • ~~Use _instigator projectile "HitPart" event handler argument instead of retrieving shotParents.~~
  • Use new syntax of nearEntities to avoid needing to sort/filter the fragment target arrays.

IMPORTANT

  • [x] If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • [x] Development Guidelines are read, understood and applied.
  • [x] Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

lambdatiger avatar Sep 12 '24 21:09 lambdatiger

Readable diff (I think) - https://github.com/lambdatiger/ace_frag-overhaul/compare/lambdatiger:ace_frag-overhaul:Event-hanlder-replacement...eventHandler-replace-2.18

PabstMirror avatar Sep 12 '24 21:09 PabstMirror

@lambdatiger Can you handle the merge conflicts?

johnb432 avatar Sep 22 '24 20:09 johnb432

There's one more 2.18 change that came from #10247 that isn't present in this PR yet. I'll test it again later this week before I commit it.

lambdatiger avatar Sep 22 '24 21:09 lambdatiger

There's one more 2.18 change that came from #10247 that isn't present in this PR yet. I'll test it again later this week before I commit it.

There's no hurry, given that 2.18 won't release until sometime in october (and I doubt we will release a day 1 patch).

johnb432 avatar Sep 23 '24 06:09 johnb432

There's no hurry, given that 2.18 won't release until sometime in october (and I doubt we will release a day 1 patch).

That aged like milk...

johnb432 avatar Oct 12 '24 20:10 johnb432

I'll run through it tomorrow and let you know if it's good to go.

lambdatiger avatar Oct 13 '24 03:10 lambdatiger

Alright, new feature isn't easily added. I'll address any other changes in #9728.

Testing seems to work like it should, no issues and the new nearEntities syntax does what it took us the command and a loop to do. If anyone has specific testing they want lmk, but I ran through in single player using the new syntax and formatting.

lambdatiger avatar Oct 13 '24 22:10 lambdatiger