WatchYourLAN icon indicating copy to clipboard operation
WatchYourLAN copied to clipboard

Feature request: track changes by MAC address

Open martinfrancois opened this issue 1 year ago • 8 comments

Every time a device with the same MAC address is receiving a new ip address through DHCP, it shows up as an unknown entry. A configurable option would be nice which would set the status of new entries having a known MAC address in a different entry to be known.

Even better would be if the MAC address was used as a primary identifier (meaning there would only be one entry per MAC address, not per IP and MAC combination), and clicking on one would show the history of previous IP's and dates.

martinfrancois avatar Sep 20 '22 14:09 martinfrancois

Same issue for me. A device should record the name even if his IP address change if the MAC address is the same.

lubomben avatar Sep 22 '22 18:09 lubomben

+1

wangeris avatar Oct 09 '22 20:10 wangeris

Not sure if any of our votes count, but considering what is truly important is to detect new HW being added, I'd add one more: +1

markus-li avatar Oct 20 '22 23:10 markus-li

This seems like essential functionality

+1

jamesmyatt avatar Oct 21 '22 12:10 jamesmyatt

I'd be up for implementing it, but I can see that other Pull Requests with requested features were Closed, so makes me hesitant to invest time into the project

wangeris avatar Oct 21 '22 12:10 wangeris

I'd be up for implementing it, but I can see that other Pull Requests with requested features were Closed, so makes me hesitant to invest time into the project

Unfortunately seems like the dev abandoned this project. @reneManqueros has a fork here that has some additional features, maybe they'd be willing to implement the change on their fork? https://github.com/reneManqueros/WatchYourLAN

sholder89 avatar Oct 21 '22 12:10 sholder89

@wangeris @sholder89 If you can please implement it, this feature was on my backlog i just hadn't reached it yet, just make sure to fork from my version as it has some changes to the datamodel that i am doing to make it interchangeable (sqlite, mongo, mysql), i am currently working on integrating it with mongo as that is a "priority" for my use case, and then will do a cleanup on the pipelines because it's still pointing to this project and not my fork. Something else that could help me over there is to create issues with any feature requests that you guys find useful. thank you

reneManqueros avatar Oct 21 '22 14:10 reneManqueros

The changes for this are committed in my fork at https://github.com/bugbounce/WatchYourLAN/commit/7ca8feeec98589640dc091424c91c862bdc13974

Although ,I have no easy way of testing it. But its a simple enough change. @reneManqueros Please check the code and pull if makes sense to you. I will raise a PR here once I have updated the Readme.

bugbounce avatar Oct 21 '22 19:10 bugbounce

+1 on this...

So this project is abandoned?

barart avatar Dec 14 '22 01:12 barart

Added option to ignore IP change. Set IGNOREIP="yes" to use it

aceberg avatar Jan 02 '23 06:01 aceberg

After update to this version im unable to start the container, im getting this error:

Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "./watchyourlan": stat ./watchyourlan: no such file or directory: unknown

barart avatar Jan 02 '23 19:01 barart

After update to this version im unable to start the container, im getting this error:

Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "./watchyourlan": stat ./watchyourlan: no such file or directory: unknown

Are you building your own docker image? Because in this release Dockerfile there is WatchYourLAN instead of watchyourlan

aceberg avatar Jan 03 '23 05:01 aceberg

Are you building your own docker image? Because in this release Dockerfile there is WatchYourLAN instead of watchyourlan

Nope, i getting the image directly from: https://hub.docker.com/r/aceberg/watchyourlan

I just upgraded it running the image from that url

barart avatar Jan 03 '23 06:01 barart

Nope, i getting the image directly from: https://hub.docker.com/r/aceberg/watchyourlan

I just upgraded it running the image from that url

Can you show me the output of docker inspect wyl | grep -i watch ? And maybe try to restart docker service?

aceberg avatar Jan 03 '23 06:01 aceberg

Can you show me the output of docker inspect wyl | grep -i watch ?

And maybe try to restart docker service?

Here you are:

docker inspect WatchLan | grep -i watch
"Path": "./watchyourlan", "Error": "failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "./watchyourlan": stat ./watchyourlan: no such file or directory: unknown", "Name": "/WatchLan", "/home/WatchLan/data:/data" "Source": "/home/WatchLan/data", "Image": "aceberg/watchyourlan:latest", "./watchyourlan"

barart avatar Jan 03 '23 06:01 barart

Can you show me the output of docker inspect wyl | grep -i watch ? And maybe try to restart docker service?

Here you are:

docker inspect WatchLan | grep -i watch "Path": "./watchyourlan", "Error": "failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "./watchyourlan": stat ./watchyourlan: no such file or directory: unknown", "Name": "/WatchLan", "/home/WatchLan/data:/data" "Source": "/home/WatchLan/data", "Image": "aceberg/watchyourlan:latest", "./watchyourlan"

Ok, it looks like docker using the old lowcase path somehow. I think deleting the container and creating a new one should help. On my servers (Ubuntu and Debian, amd64) the update went flawlessly, so, maybe, it's the version of docker you are using, I'm not sure.

aceberg avatar Jan 03 '23 06:01 aceberg

Ok, it looks like docker using the old lowcase path somehow. I think deleting the container and creating a new one should help. On my servers (Ubuntu and Debian, amd64) the update went flawlessly, so, maybe, it's the version of docker you are using, I'm not sure.

I see, for some reason even when recreating it, the Entrypoint record was not updated, i changed it and recreate the container and it worked

Thanks a lot!

barart avatar Jan 03 '23 17:01 barart