Ace Nassri

Results 57 comments of Ace Nassri

> Unit tests prevent logical regressions ASAP. A good candidate for this would be any tricky logic, especially where it can cascade and break other tests in mysterious ways I'm...

Added a link to `go/emblem-website-testing-plan`, where this info is documented.

There are two requests here: 1. a `POST` to `/donate` to submit the donation 2. a `GET` [redirect] to `/viewDonation` to view the resulting donation Currently, #620 only shows the...

[Example fix](https://github.com/GoogleCloudPlatform/emblem/pull/733) as of December 13th, 2022

We discussed this during a meeting today; @grayside seems in favor of the **sequential testing** approach. I'm fine with that, so long as we're fine with the (major) tradeoff: >...

~This is 🚨 **semi-blocked** 🚨 on #414 (to minimize churn / merge conflicts).~ **Update:** > I spoke with @pattishin, and we thought this is worth doing even without notifications. @grayside...

[`cleanup.sh`](../blob/main/cleanup.sh) might be a good starting point.

**TODO:** @ace-n to collaborate with @glasnt and see what the best approach is. _(Context: currently, our CI processes run in **Cloud Build**.)_

~~This is 🚨 **blocked** 🚨 on [this PR](https://github.com/GoogleCloudPlatform/cloud-build-notifiers/pull/141)~~ That PR has since been merged, so this is unblocked. **Ideally**, I'd implement this collaboratively with someone else. _(It's a great ~opportunity~...

There are currently **three** nightly tests running in our Emblem setup, per our [testing documentation](../tree/main/docs/testing.md): 1. Content API 2. Installation Test 3. Website @rogerthatdev and I will create separate PRs...