react-remarkable icon indicating copy to clipboard operation
react-remarkable copied to clipboard

Update with various suggested PRs

Open beausmith opened this issue 6 years ago • 6 comments

@acdlite - I needed a bunch of bits which other people had solved so I pulled or reimplemented them. It would be great to get all this pulled over to your "official" repo.

Please review carefully, I'm sure there are a few things which could be done be a better way… specifically the creation of dist/index.js.

beausmith avatar Jul 28 '18 11:07 beausmith

since this has gone ignored, perhaps you'd like to publish your fork to npm? namespace it under your user if you'd prefer

DanielFGray avatar Oct 29 '18 21:10 DanielFGray

@DanielFGray - Sure is great to have maintained projects, eh! While I'm flattered by your suggestion… I'm not confident that I'm the right person to take this task on… though anything is possible.

beausmith avatar Oct 30 '18 21:10 beausmith

Personally, I don't think whether you're the right person is even a question, you've already done the work of merging other pulls, and that already makes you the right person from where I'm standing.

I'm not asking you to "maintain" it anymore than it is here, but to just make your work more accessible.

DanielFGray avatar Oct 31 '18 02:10 DanielFGray

Hi @beausmith , @DanielFGray ,

Do you know if this project is still active? Lifecycle methods are changing https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html, and react gives warning Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

I believe a small change might be required for this project, and @beausmith branch looks like the best starting point..

any thoughts on this?

Thank you, Mino

minotogna avatar Aug 17 '19 19:08 minotogna

Any update on this?

alexmorleyfinch avatar Jun 29 '20 13:06 alexmorleyfinch

@alexmorleyfinch - I wish I had the time to maintain a project like this… alas, I do not.

beausmith avatar Jun 29 '20 20:06 beausmith