change-emitter icon indicating copy to clipboard operation
change-emitter copied to clipboard

LICENSE file

Open Eli-Black-Work opened this issue 6 years ago • 7 comments

Hello,

Would you mind adding a LICENSE file for the project?

Eli-Black-Work avatar Sep 14 '18 03:09 Eli-Black-Work

isnt this not enough? https://github.com/acdlite/change-emitter/blob/master/package.json#L26

istarkov avatar Sep 14 '18 05:09 istarkov

Hi @istarkov! I wasn't expecting such a quick reply :)

Unfortunately, I don't think that's enough. The MIT license says in it that "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.", which I think means that the full license text needs to be included in the project somewhere.

This has been getting some attention in other repositories, too. For example, https://github.com/facebook/regenerator/issues/354

Eli-Black-Work avatar Sep 14 '18 07:09 Eli-Black-Work

Strange west world ;-) Please provida a PR Ill accept

istarkov avatar Sep 14 '18 07:09 istarkov

Hi @istarkov.

Thanks for the reply.

Since I'm at work, I'm not sure if I'll be able to provide a PR, sorry. Anyway, it looks like we're no longer using this package, so this is no longer an issue for us, at least.

Thanks again for your replies :)

Eli-Black-Work avatar Oct 03 '18 09:10 Eli-Black-Work

Can we get the PR merged?

edgan avatar Jul 06 '22 14:07 edgan

@istarkov @acdlite +1 on merging the license pull request.

emmahsax avatar Jul 19 '22 16:07 emmahsax

@istarkov and @acdlite Can we get a merge on merging the license file PR? I think multiple people would appreciate it!

emmahsax avatar Aug 03 '22 14:08 emmahsax