accounts
accounts copied to clipboard
request-promise is deprecated
Bug report
https://github.com/request/request-promise#deprecated
Describe the bug
I just noticed that the oauth package relies on request (or request promise) which is no longer maintained.
"@accounts/oauth@^0.24.0":
version "0.24.0"
resolved "https://registry.yarnpkg.com/@accounts/oauth/-/oauth-0.24.0.tgz#e9968428688f5820d8e0242bd47d97a4e5a23877"
integrity sha512-rcF8wzR6sMHA1HKf2NX7VrCLJbgJf/+AP98AupcyawwXO48OOU39gYDeH/MFjpVaqMx1qri78k9oCKB8ppfpWg==
dependencies:
"@accounts/types" "^0.24.0"
-> request-promise "^4.2.5"
tslib "1.10.0"
To Reproduce
Install @accounts/oauth
Expected behavior
No deprecated packages being imported
System information
- Version of accounts-js: [e.g. 0.0.24]
Additional context
I think this is not a super urgent issue, but one i'd like to fix at some point :sweat_smile:
For one, It seems this dependency is only used by oauth-instagram, not by oauth package itself.
I think it should be safe to remove it from main oauth, and trying to replace it in instagram.
Will submit a PR later!
Closed automatically by github when the pr was merged, but it's actually not fixed
It needs to be replaced/removed first from oauth-instagram authenticacte(), right?
@agustif yup 👍
This is planned for 1.0 but won't be there in the first release candidate: oauth will get some love in later rcs.