web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Dependencies Cleanup

Open jolanglinais opened this issue 4 years ago • 8 comments

Need to take a hard look at all our dependencies.

This impacts security, development workflow (slow builds), and page load times.

jolanglinais avatar Apr 30 '20 14:04 jolanglinais

@irmerk Shall I work upon this issue.

Cronus1007 avatar Mar 10 '21 12:03 Cronus1007

@irmerk I have checked the package=markdown-editor and the dependencies that didn't show up are rimraf and npm -run-all.These were stale dependencies and few dependencies like is-url are also missing.

Cronus1007 avatar Mar 10 '21 15:03 Cronus1007

@irmerk So shall I start working upon this issue.

Cronus1007 avatar Mar 10 '21 22:03 Cronus1007

Could you please outline what you plan to change here before opening a PR?

jolanglinais avatar Mar 11 '21 16:03 jolanglinais

@irmerk Here the things that I noticed before opening a PR is that I checked each file of the package twice and saw that the package doesn't depend upon the two dependencies like rimraf and npm-run-all.These have their usecase in storybook package only and it is safe to remove these dependencies from the package.

Cronus1007 avatar Mar 11 '21 16:03 Cronus1007

@irmerk Can you assign this to me? My approach is to use depcheck to analyze dependencies by using the information provided by npm

Hanaffi avatar Mar 15 '21 16:03 Hanaffi

@Hanaffi Good spot.But depcheck has its own limitation. When I ran npx depcheck then I got this. Screenshot from 2021-03-15 21-51-21

In dev dependecies I agree with only rimraf and npm-run-all Here dependencies of rollup,stylelint,lint-staged were used but depcheck ignored those since it doesn't check .rc , .config.js etc files. So it can't be relied much. Here I agree that is-url should be added but other dependencies weren't required as it can perform it's function without them as well.

So it will require a manual checkup rather than automated

Cronus1007 avatar Mar 15 '21 16:03 Cronus1007

Sorry for the delay, I think this makes sense @Cronus1007

jolanglinais avatar Apr 02 '21 13:04 jolanglinais