web-components
web-components copied to clipboard
Dependencies Cleanup
Need to take a hard look at all our dependencies.
This impacts security, development workflow (slow builds), and page load times.
@irmerk Shall I work upon this issue.
@irmerk I have checked the package=markdown-editor
and the dependencies that didn't show up are rimraf
and npm -run-all
.These were stale dependencies and few dependencies like is-url
are also missing.
@irmerk So shall I start working upon this issue.
Could you please outline what you plan to change here before opening a PR?
@irmerk Here the things that I noticed before opening a PR is that I checked each file of the package twice and saw that the package doesn't depend upon the two dependencies like rimraf
and npm-run-all
.These have their usecase in storybook
package only and it is safe to remove these dependencies from the package.
@irmerk Can you assign this to me?
My approach is to use depcheck
to analyze dependencies by using the information provided by npm
@Hanaffi Good spot.But depcheck
has its own limitation. When I ran npx depcheck
then I got this.
In dev dependecies I agree with only rimraf
and npm-run-all
Here dependencies of rollup,stylelint,lint-staged
were used but depcheck ignored those since it doesn't check .rc
, .config.js
etc files. So it can't be relied much. Here I agree that is-url
should be added but other dependencies weren't required as it can perform it's function without them as well.
So it will require a manual checkup rather than automated
Sorry for the delay, I think this makes sense @Cronus1007