web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Quoting in Cicero UI doesn't seem to handle nested structures as the Md editor

Open jeromesimeon opened this issue 5 years ago • 8 comments

Quoting in the markdown editor properly preserves the structure of the selected part of the document:

QuoteMarkdownEditor

It seems to lose the structure when quoting in Cicero UI:

QuotingCiceroUI

It could be an artefact of the demo, but might be useful to investigate.

jeromesimeon avatar Mar 12 '20 19:03 jeromesimeon

It is due to the improper text selection. Actually while text selection the bulleted list or the numbered list is getting selected. It works fine in both cicero-ui and markdown editor when I select the structure without selecting the bullet list or numbered list. As you have selected in the markdown editor. Even the markdown editor also does not preserves the selected structure when numbered or bulleted list is selected this is the snippet of markdown editor I which at end you can observe when I selected the text the bulleted list got seleted and when I clicked the quote it did not preserved the nested structure mdeditor

In cicero ui I observe when the selected text where bulleted list is not selected then it is preserved cicero-ui-bug

imnik11 avatar Mar 31 '20 09:03 imnik11

@imnik11 this may be fixed when we migrate to Slate v0.57, being tracked here and here.

jolanglinais avatar Mar 31 '20 13:03 jolanglinais

@imnik11:

accordproject/cicero-ui#357 (and accordproject/markdown-editor#297) has been finished, so there is no longer a blocker on this issue. The migration may have solved this issue, so look into that first.

jolanglinais avatar Apr 10 '20 20:04 jolanglinais

No the issue still persist. I think it is due to the selection of bulleted list / numbered list while quoting as shown in the markdown editor https://user-images.githubusercontent.com/45528152/78009656-f8696c00-735e-11ea-96dd-aec62f3f7e03.gif and ciceri ui https://user-images.githubusercontent.com/45528152/78010554-1e434080-7360-11ea-82e2-8b93c93c6118.gif

imnik11 avatar Apr 11 '20 16:04 imnik11

Alright thanks for checking! I think this issue is just in markdown-editor, which is where we would be handling this logic. Moving it there.

jolanglinais avatar Apr 12 '20 19:04 jolanglinais

Update: still persists.

jeromesimeon avatar Sep 14 '20 17:09 jeromesimeon

I can reproduce this in the Markdown Editor - so it's nothing to do with the Contract Editor.

dselman avatar Sep 14 '20 17:09 dselman

I can reproduce this in the Markdown Editor - so it's nothing to do with the Contract Editor.

Original issue was filed pre-slate 0.57 pre-web-components

jeromesimeon avatar Sep 14 '20 17:09 jeromesimeon