web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Markdown support: Code blocks

Open jeromesimeon opened this issue 6 years ago • 5 comments

Is your feature request related to a problem? Please describe. Code blocks are a useful markdown feature. It would be nice if the editor supports them.

Describe the solution you'd like The ability to create/edit/delete code blocks.

Maybe the ability to turn into a selection into a code block would be nice as well/

jeromesimeon avatar Nov 12 '19 23:11 jeromesimeon

@jeromesimeon @irmerk Did some work to add the feature. Here is a recording. https://www.loom.com/share/238dbd1abb1e4a159038d113c61860aa

Is this feature correct? Let me know if there are any changes required.

some things to note:

  1. the icon used is similar to the code icon
  2. Shortcut key does not work currently

K-Kumar-01 avatar Mar 06 '21 09:03 K-Kumar-01

@jeromesimeon @irmerk Requesting your review

K-Kumar-01 avatar Mar 10 '21 17:03 K-Kumar-01

Should this support start in markdown-transform @jeromesimeon?

jolanglinais avatar Mar 10 '21 22:03 jolanglinais

Should this support start in markdown-transform @jeromesimeon?

We already support code blocks in the markdown-transform

The video looks nice. Sadly the bottom of the screen doesn't show the markdown for that part of the document (I don't think?) so it's difficult to say if what's in the editor gets properly translated to a markdown block.

@K-Kumar-01 This looks great. If you have another video, or maybe even better a PR we could evaluate your proposal better!

jeromesimeon avatar Mar 10 '21 22:03 jeromesimeon

Use https://github.com/accordproject/web-components/pull/289 as reference when starting this.

jolanglinais avatar Nov 30 '21 21:11 jolanglinais