web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Handle Underline in Markdown

Open jolanglinais opened this issue 5 years ago • 7 comments

To Be Done Instead of OR After Issue #27

Since transitioning to utilize the markdown-transform, we will need to take a step back from supporting underline for the time being. Markdown doesn't natively support underline, so we need to rethink how we serialise this.

We can then experiment with using html tags for underline.

jolanglinais avatar Oct 03 '19 19:10 jolanglinais

Since issue accordproject/markdown-editor#97 is now closed, can I start working on this?

ahmedkrmn avatar Oct 05 '19 20:10 ahmedkrmn

Yes @ahmedkrmn! Keep a lookout for the changes @dselman and I are making with the markdown-transform, because there may be an update that could possibly affect how you approach this. Not sure if it actually will, just keep an eye out. We should be finished with that either tomorrow or early Monday (October 6/7).

jolanglinais avatar Oct 05 '19 22:10 jolanglinais

@ahmedkrmn what is the status of this? I'm opening it back up for the time being.

jolanglinais avatar Oct 17 '19 14:10 jolanglinais

@irmerk Can I look into this?

d-e-v-esh avatar Mar 23 '21 13:03 d-e-v-esh

@d-e-v-esh I believe this may actually require thinking/work in https://github.com/accordproject/markdown-transform first. It could be worth opening an Issue there to discuss how to (or if to) handle underline in markdown.

jolanglinais avatar Mar 23 '21 13:03 jolanglinais

@irmerk Yes. I think we can open another issue on this. Underlining text seems like it could be important for people dealing with contracts. Should I open another issue on this? This one will get closed?

d-e-v-esh avatar Mar 24 '21 05:03 d-e-v-esh

If you could open one in markdown-transform and link this one, we can put a pause on this one until that new one is resolved.

jolanglinais avatar Mar 25 '21 12:03 jolanglinais