web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Docs for Delete Edit and Test Icons

Open K-Kumar-01 opened this issue 4 years ago • 14 comments

Bug Report 🐛

Click on Delete Icon is not working when the cursor hovers over clause templates. Package: Contract Editor

Expected Behavior

The template should get deleted.

Current Behavior

There is no deletion of the template.

Steps to Reproduce

  1. Hover any template
  2. Click on delete icon

Context (Environment)

Desktop

  • OS: ZorinOs(Ubuntu based)
  • Browser: Chrome
  • Version: Chrome- 88.0.4324.182 (Official Build) (64-bit), Zorin OS 15.3

K-Kumar-01 avatar Feb 27 '21 06:02 K-Kumar-01

This is likely an issue with how the icon is used in our Storybook.

jolanglinais avatar Mar 02 '21 15:03 jolanglinais

@irmerk I don't think that the edit button works either. That button is supposed to let us edit the contract, isn't it?

d-e-v-esh avatar Mar 07 '21 07:03 d-e-v-esh

I am trying to resolve this!

lokeshn011101 avatar Mar 07 '21 16:03 lokeshn011101

Addon action 'delete' is working as it is showing it in the action console.

codetheorem avatar Mar 07 '21 19:03 codetheorem

@lokeshn011101 What do you think that the problem is?

d-e-v-esh avatar Mar 08 '21 04:03 d-e-v-esh

I can't seem to find where these 3 functions are defined in the code nor the main props of the application. I am not sure if these three functions are defined yet. Code_Q6kl0n9ca2

The only thing that I could find yet is this. Code_uLx1oZzzTH

All this does is log stuff on the actions console.

d-e-v-esh avatar Mar 08 '21 05:03 d-e-v-esh

This is working as designed -- these functions can be supplied by the user of the component. They are not implemented by default because they typically require interaction with other components or the persistence layer of the embedding application.

A nice PR would be to update the README with details like this and how to use the component in general.

dselman avatar Mar 08 '21 11:03 dselman

@irmerk Shall I work upon this issue.

Cronus1007 avatar Mar 15 '21 14:03 Cronus1007

@irmerk @dselman Before opening the PR the plan that I am intending to follow is :-

  • [ ] First of all the file that I am going to update is link
  • [ ] Documenting the role of the user in the Component
  • [ ] Documenting how to use them in general.

If some sort of addition or deletions are there let me know.

Cronus1007 avatar Mar 15 '21 16:03 Cronus1007

@Cronus1007 I believe that sounds like a good plan.

jolanglinais avatar Mar 15 '21 17:03 jolanglinais

I would like to contribute and fix the issue. Can you guide me on how should I go forward into solving this issue.

dezfuture avatar Mar 26 '21 12:03 dezfuture

@dezfuture as you can see, @Cronus1007 is working on this and has an open PR.

jolanglinais avatar Mar 26 '21 13:03 jolanglinais

Is this issue resolved?

mansigrover09 avatar Jan 15 '23 16:01 mansigrover09

No, but there is a solution in https://github.com/accordproject/web-components/pull/305 if you want to open a new PR. Please consider the feedback given in the thread in #305

mttrbrts avatar Jan 17 '23 21:01 mttrbrts