web-components icon indicating copy to clipboard operation
web-components copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Autoscroll during drag-and-drop of a clause

Open dselman opened this issue 5 years ago • 17 comments

Feature Request 🛍️

Drag-and-drop of clauses within a contract is of limited value, because the contract doesn't autoscroll when you get near the top or the bottom of the visible part of the contract.

Use Case

Create a long contract. Decide you'd like to move a clause from the beginning to the end of the contract.

Possible Solution

Some sort of autoscroll of the contract.

dselman avatar Jul 02 '20 10:07 dselman

Hello @dselman I would like to work on this feature. Is this still open?

sanketshevkar avatar Sep 05 '20 16:09 sanketshevkar

Hello @dselman I would like to work on this feature. Is this still open?

Hi @sanketshevkar As far as I can tell this is still open. You can test it on the storybook.

https://ap-web-components.netlify.app/?path=/story/contract-editor--contract-editor

I'll assign you. CC @irmerk

jeromesimeon avatar Sep 05 '20 16:09 jeromesimeon

Ok cool. Thanks @jeromesimeon

sanketshevkar avatar Sep 05 '20 16:09 sanketshevkar

Hi @dselman, I would like to work on this issue if it is still open

TC5022 avatar Dec 03 '21 10:12 TC5022

@sanketshevkar are you still working on this issue? If not, I will assign to @TC5022

Michael-Grover avatar Dec 03 '21 16:12 Michael-Grover

@sanketshevkar are you working on it?

TC5022 avatar Dec 06 '21 13:12 TC5022

Sorry @TC5022 @Michael-Grover. Nope I'm not working on this issue.

sanketshevkar avatar Dec 07 '21 16:12 sanketshevkar

@irmerk @Michael-Grover thank you for assigning me the issue. Is it possible to contact you regarding some doubts related to this?

TC5022 avatar Dec 08 '21 13:12 TC5022

Hi @TC5022 , if you have questions, you can put them in this issue

Michael-Grover avatar Dec 08 '21 16:12 Michael-Grover

@Michael-Grover @irmerk I think the issue could be solved using the autoscroll-react package but according to their documentation, it uses a ref. So, I am thinking to add the useRef hook. Does it sound good to proceed?

TC5022 avatar Dec 10 '21 13:12 TC5022

@dselman @DianaLease

Michael-Grover avatar Dec 13 '21 19:12 Michael-Grover

The changes I am making in the contract editor code aren't reflected in the storybook. Could you please guide me as to why this is happening? @dselman @DianaLease

TC5022 avatar Dec 21 '21 16:12 TC5022

Did you check the README? I think there are some notes there for what you need to do to rebuild.

dselman avatar Dec 21 '21 16:12 dselman

Yes i resolved it, there was an issue with my system. Sorry for the trouble.

TC5022 avatar Dec 21 '21 17:12 TC5022

Please open a PR when you have something with autoscroll-react so we can review how that could work here.

jolanglinais avatar Dec 21 '21 17:12 jolanglinais

Sure, I have almost worked up the code. Will open a PR as soon as I get it finalised

TC5022 avatar Dec 21 '21 18:12 TC5022

Hey Can I work on this or is this solved?

KhushV25 avatar Jul 14 '23 14:07 KhushV25