Type definitions for DCS

[sanketshevkar]

Bug Report 🐛

Type definitions for a DCS model are missing. Add generated typescript types of DCS Concerto Model to concerto-types module.

Expected Behavior

Type of DCS object should be centrally defined in concerto-types.

Possible Solution

We'll require a code generation script similar to this that will convert the DCS concerto model to its corresponding typescript definitions.

[Ayush1404]

Hi @sanketshevkar,

I hope you're doing well! I'm interested in contributing, but I'm having a bit of trouble understanding the issue. Could you kindly provide a bit more detail or clarify it for me?

Thanks so much in advance!

[sanketshevkar]

Hi @Ayush1404 I've updated the issue description with some reference link.

[Ayush1404]

@sanketshevkar thank you , i will look into it

[sanketshevkar]

@Ayush1404 just a heads up, I might pick this up next week on Wednesday, if not already started. Please let me know if you'd already started work on this.

[Ayush1404]

hey @sanketshevkar , sorry for the late reply , was a little busy due to college exams . We can do two things we can make changes in existing code-gen script to include DCS_MODEL from the decoratormanager.js file like this or we can generate a new script , something like this what do you think , which one do you think should we go for ?

[sanketshevkar]

Thanks @Ayush1404. I'm sorry I don't want to bother you during your exams, hope you are done with them.

The first approach seems fit to to me.

[Ayush1404]

@sanketshevkar No problem , the exams are over now . Do i have to make any changes in it , before making a PR ?

[sanketshevkar]

Idts, maybe just raise the PR following our contributors guideline and do not forget the DCO-Signoff :)

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[sanketshevkar]

@Ayush1404 are you still working on this.

[fuyalasmit]

Hi @sanketshevkar, I noticed this issue is in the backlog I'd be happy to work on this, would you assign this to me ?

[fuyalasmit]

I saw the codebase meanwhile, and I have thought of a roadmap to solve the issue:

1. Load the DCS_MODEL from decoratormanager.js to modelManager
2. Then, process the model using TypescriptVisitor
3. Writing into correct output directory

[TC5022]

Hi @fuyalasmit , are you still working on this issue?

[fuyalasmit]

Hi @fuyalasmit , are you still working on this issue?

Hi, I suggested a approach in brief before, but I was involved in other issues in the meantime. However, I'm planning to look at this one again soon. If you're interested, we could collaborate on solving it together. Let me know if that works for you!

[TC5022]

Hi @fuyalasmit , are you still working on this issue?

Hi, I suggested a approach in brief before, but I was involved in other issues in the meantime. However, I'm planning to look at this one again soon. If you're interested, we could collaborate on solving it together. Let me know if that works for you!

Sure, let's work it together. Have you made any changes in the code already?

[fuyalasmit]

Haven't made any changes regarding this issue, I was waiting for the maintainer to respond since he stated

a new PR is to be opened in concerto-metamodel repo here

By the way, have you thought of any approach to tackling this?

[TC5022]

Yeah I went through the codebase, and I think the approach stated by you works well, we will have to update the existing codegen script and include the DCS model in it. We will just have to be careful about exporting the DCS model correctly.

@sanketshevkar could you please assign us this issue? Should I open a PR in the concerto-metamodel repo with starter changes ? Then we can see how it goes from there, maybe make changes together, if needed.

Haven't made any changes regarding this issue, I was waiting for the maintainer to respond since he stated

a new PR is to be opened in concerto-metamodel repo here

By the way, have you thought of any approach to tackling this?

[fuyalasmit]

Okay, if you are starting, make sure you clone this and work here, so that it will be easier for me too, since I already have it set up locally. I couldn’t see your fork, so collaborating this way will help. Also, make sure you use co-authored commits.

[TC5022]

Okay, if you are starting, make sure you clone this and work here, so that it will be easier for me too, since I already have it set up locally. I couldn’t see your fork, so collaborating this way will help. Also, make sure you use co-authored commits.

We will first have to define the DCS model in this repository (linked my fork) instead of concerto and export it from there. After that we will have to import it here so that the overall exports work.

@sanketshevkar, I wanted to clarify where should I define the DCS model in the concerto-metamodel repo. Will defining it as a variable in the utils file work?

[sanketshevkar]

Apologies I was caught up in some work. I'm assuming @Ayush1404 is no longer working on this issue. But I'll still wait for his response.

[sanketshevkar]

@TC5022 I've requested changes on your PR. Once those are in. Can @fuyalasmit or you just clone @Ayush1404 's changes and update import there?

With this we can have your both as well as @Ayush1404 's changes in the codebase. I don't want anyone's work get wasted here. Please avoid doing a FORCE PUSH to the PR we'll loose the commits.

[fuyalasmit]

yeah sure, @TC5022 will do the needed work in concerto-metamodel, when it gets done there, I'll fix the changes for type definition for DCS is that okay ?

[fuyalasmit]

hey, what's the progress so far ?

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.