concerto icon indicating copy to clipboard operation
concerto copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Added error codes to property validation errors

Open subhajit20 opened this issue 10 months ago • 2 comments

Closes #834

  • removed plain error and added IllegalModelException and TypeNotFoundException

Author Checklist

  • [x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • [ ] Vital features and changes captured in unit and/or integration tests
  • [ ] Commits messages follow AP format
  • [ ] Extend the documentation, if necessary
  • [ ] Merging to main from fork:branchname

subhajit20 avatar Apr 05 '24 14:04 subhajit20

What type of exception is this one? will it be falling under base exception @ekarademir

https://github.com/accordproject/concerto/blob/abd1c8ee15711ba0cea99a2476fbf01650a05fd4/packages/concerto-core/lib/introspect/property.js#L181-L184

Usually IllegalModelException

ekarademir avatar Apr 05 '24 16:04 ekarademir

What type of exception is this one? will it be falling under base exception @ekarademir https://github.com/accordproject/concerto/blob/abd1c8ee15711ba0cea99a2476fbf01650a05fd4/packages/concerto-core/lib/introspect/property.js#L181-L184

Usually IllegalModelException

Okay, Hey have added that. Can. you once review this and give me some feedback.

subhajit20 avatar Apr 05 '24 16:04 subhajit20