concerto icon indicating copy to clipboard operation
concerto copied to clipboard

A new helper method in Decorator class to resolve types for type references decorators

Open RINO-GAELICO opened this issue 11 months ago • 1 comments

…r type references decorators. Failed tests with Error message: Internal error: local types are not yet initialized. Do not try to resolve types inside . The error is thrown by ModelFile.getLocalType method. Inside the _resolveArguemntType method the call that lead to the error is modelFile.getType(argument.type.name)

Closes #<#797>

As requested by @sanketshevkar I created this draft pull request to allow him to dig up into this.

Changes

  • A new helper method in Decorator class to resolve types for type references decorators >
  • Failed tests with Error message: Internal error: local types are not yet initialized. Do not try to resolve types inside . The error is thrown by ModelFile.getLocalType method. Inside the _resolveArguemntType method the call that lead to the error is modelFile.getType(argument.type.name)

Flags

Screenshots or Video

Related Issues

  • Issue #798
  • Pull Request #<NUMBER>

Author Checklist

  • [ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • [ ] Vital features and changes captured in unit and/or integration tests
  • [ ] Commits messages follow AP format
  • [ ] Extend the documentation, if necessary
  • [ ] Merging to main from fork:branchname

RINO-GAELICO avatar Mar 15 '24 18:03 RINO-GAELICO

Regarding this comment from the issue.

Yes, you're findings seem correct to me. For this, I think we can use this in the validate method.

@mttrbrts @dselman will this be a good approach?

sanketshevkar avatar Mar 22 '24 06:03 sanketshevkar