concerto icon indicating copy to clipboard operation
concerto copied to clipboard

hereje/i763/refactor/migrate to esm/concerto types

Open hereje opened this issue 2 years ago • 2 comments

Closes #763 => packages/concerto-types <CORRESPONDING ISSUE NUMBER>

Changes

  • convert project to ESM
  • update script and test files accordingly

Flags

  • Jest configuration on package.json

Screenshots or Video

Related Issues

  • Issue #<NUMBER>
  • Pull Request #<NUMBER>

Author Checklist

  • [x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • [x] Vital features and changes captured in unit and/or integration tests
  • [x] Commits messages follow AP format
  • [x] Extend the documentation, if necessary
  • [x] Merging to main from fork:hereje/i763/refactor/migrate-to-esm/concerto-types

hereje avatar Jan 09 '24 18:01 hereje

Hi @hereje, as this is a breaking change, we need to target the v4 branch. Are you willing to rebase this on top of that branch, please?

mttrbrts avatar Feb 27 '24 13:02 mttrbrts

@hereje can you rebase your changes on top of the latest v4.0.0 branch, please? I see that this PR has lots of unrelated changes now too

mttrbrts avatar Mar 10 '24 16:03 mttrbrts