Remove backticks from mermaid code

[sanketshevkar]

Bug Report 🐛

The mermaid code generation results in a correct expected code, but with backticks around properties and their types.

Expected Behavior

classDiagram
class `[email protected]` {
<< concept>>
   + String id
}

class `[email protected]` {
<< concept>>
   + String name
}

Link

Current Behavior

classDiagram
class `[email protected]` {
<< concept>>
   + `String` `id`
}

class `[email protected]` {
<< concept>>
   + `String` `name`
}

Link

[shubhalgupta]

please assign this to me!

[shubhalgupta]

[shubhalgupta]

How to save and do a PR? @sanketshevkar

[sanketshevkar]

You can refer to this. Also please make a fork of codegen repo.

[sanketshevkar]

Also which repo have you made the changes? @shubhalgupta

[shubhalgupta]

@sanketshevkar I am raising a PR and I made changes just to the link you provided!

[shubhalgupta]

@sanketshevkar I am not getting the mermaid code, can you please where is it present? but I have got mermaid visitor file.

[sanketshevkar]

@sanketshevkar I am raising a PR and I made changes just to the link you provided!

The link I provided is just a reference to code-generation output we are expecting.

[sanketshevkar]

@sanketshevkar I am not getting the mermaid code, can you please where is it present? but I have got mermaid visitor file.

There is no mermaid code as such. The mermaid code is a result of code generation that happens using the mermaid visitor in the codegen repo I suggested you to clone yesterday. The model is converted to mermaid code. Please refer to docs. This shall help you. https://concerto.accordproject.org/docs/reference/codegen/codegen-mermaid https://concerto.accordproject.org/docs/reference/codegen/codegen-create-new

[Shubham1450]

I want to contribute but not able to find the code. please help! @sanketshevkar

[sanketshevkar]

@Shubham1450 , bug might somewhere here. https://github.com/accordproject/concerto-codegen/blob/main/lib/codegen/fromcto/mermaid/mermaidvisitor.js Please do investigation from your side.

[Shubham1450]

@sanketshevkar how to set up this project locally.

[subhajit20]

hey @sanketshevkar I have made a pr. Can you check once and let me know if any changes needed.

[apoorvsxna]

Hi @sanketshevkar. I have managed to fix this issue by modifying the mermaidvisitor.js file located in the concert-codegen repository.

I have understood the contribution guidelines and would like to make a pull request, which I assume I would have to do in the concert-codegen repository (?).

The guidelines indicate that each pull request should link to the issue it closes. However, this particular issue is not listed in the concert-codegen repo. How should I proceed?

(This would be my first pull request. Sorry if I'm asking an obvious question.)

[sanketshevkar]

Hi @apoorvsxna I believe @subhajit20 has PR up for review already. If you'd still like to contribute, you can review @subhajit20's PR and offer some suggestions if you'd have any. Let's not duplicate our efforts.

Coming back to attaching a ticket, you can create a new ticket on codegen repo and link it here. And also link it in your PR.

[Thanush19]

hey @subhajit20 , if the issue is not fixed , i can work on this