concerto icon indicating copy to clipboard operation
concerto copied to clipboard
verified publisher icon accordproject

breaking change(core): Stabilize namesapce target for decorator commands

Open fuyalasmit opened this issue 9 months ago • 1 comments

Closes #1007

Changes

  • Removed behavior where namespace targeted decorators were applied to all declarations, taking reference from #877
  • Removed the enableDcsNamespaceTarget option, making the new behavior (applying decorators only to the namespace) the default
  • Updated tests in test/decoratormanager.js

Author Checklist

  • [x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • [x] Vital features and changes captured in unit and/or integration tests
  • [x] Commits messages follow AP format
  • [x] Extend the documentation, if necessary
  • [x] Merging to v4.0.0 from fuyalasmit/concerto:asmit/1007

fuyalasmit avatar Apr 02 '25 17:04 fuyalasmit

why did this check fail, can you help me figure out this please ?

fuyalasmit avatar Apr 02 '25 17:04 fuyalasmit

why did this check fail, can you help me figure out this please ?

It appears to have been an intermittent issues with our third-party provider that tracks code coverage. I've retried the failed steps.

mttrbrts avatar Apr 05 '25 19:04 mttrbrts

@mttrbrts shouldn't v4 branch be always ahead of the main?

What I am expecting is to rebase v4 against main and then just remove the flag checks in Decorator manager. I'm not sure if its a good idea to copy or replicate every feature from main in v4 branch.

sanketshevkar avatar Apr 07 '25 07:04 sanketshevkar

@sanketshevkar in principle, yes, but we're running behind so will need to cherry pick commits to catch up the v4 branch

mttrbrts avatar Apr 07 '25 08:04 mttrbrts

@sanketshevkar in principle, yes, but we're running behind so will need to cherry pick commits to catch up the v4 branch

what shall be my next step then ? do I need to cherry pick the commit from here, and then update this PR accordingly or what ? could you guide me please ?

fuyalasmit avatar Apr 10 '25 06:04 fuyalasmit

do I need to cherry pick the commit from here, and then update this PR accordingly or what ? could you guide me please ?

That PR is nearly ready to merge, let's merge it and then you can cherry pick the changes.

mttrbrts avatar Apr 12 '25 19:04 mttrbrts

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 28 '25 02:04 github-actions[bot]

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 14 '25 02:05 github-actions[bot]