cicero-word-add-in-deprecated icon indicating copy to clipboard operation
cicero-word-add-in-deprecated copied to clipboard

Published 20 hours ago • verified publisher icon accordproject

Add husky, lint-staged and prettier

Open nik72619c opened this issue 4 years ago • 5 comments

Type

  • Refactor

Description

Addition of husky and lint-staged would avoid committing poor code to the repository

nik72619c avatar Mar 10 '20 13:03 nik72619c

What is the benefit here? I'm not sure we need this.

jolanglinais avatar May 04 '20 13:05 jolanglinais

@irmerk this can ensure that the developers do not introduce untidy/faulty code to the repo. But if you think we don't need it, we can remove it up :)

nik72619c avatar May 04 '20 13:05 nik72619c

Hmm, yeah I think this could be an opportunity to sync our repos. Looking at some as examples, markdown-editor and cicero-ui has linting, but markdown-transform and concerto-ui does not.

Any thoughts on this @jeromesimeon @DianaLease @mttrbrts @dselman? I imagine we would sync things with how we have it in cicero-ui.

jolanglinais avatar May 04 '20 14:05 jolanglinais

It may be easier to standardise how we do all this once we move to the web-components mono repo?

dselman avatar May 04 '20 14:05 dselman

It may be easier to standardise how we do all this once we move to the web-components mono repo?

Yes indeed, I wasn't sure that was definite yet.

jolanglinais avatar May 04 '20 14:05 jolanglinais