feat(TemplateList): identify variables and add content controls - I121

Open sachdeva-shrey opened this issue 5 years ago • 5 comments

Signed-off-by: Shrey Sachdeva [email protected]

Issue #121

Identify different nodes in CiceroMark DOM to add styling and content controls on the Variable and ComputedVariable nodes.

Changes

Heading node now enters a new Paragraph, a line break and styling is adjusted appropriately.
Paragraph node is further identified as 4 types: -- Text: Plain text is inserted -- Softbreak: Adds a line break -- Variable & ComputerVariable: Content controls are added with styling

Flags

Apr 08 '20 12:04 sachdeva-shrey

Please review @DianaLease @dselman. Thanks!

Apr 10 '20 14:04 sachdeva-shrey

We don't seem to process any of the child nodes of a paragraph (or other nodes that could have children). This may lead to data loss for complex templates (e.g. a para containing a list containing list items which are paras).

Yes, I added the support for List, ListVariable and Item nodes. I also took the volume discount to list template and it seems to render well in the document. Are there any other complex examples I should try this with? content_control_1

Apr 10 '20 19:04 sachdeva-shrey

@DianaLease not sure what happened with the rebase here. Can you please suggest how I can fix the DCO check?

Apr 10 '20 19:04 sachdeva-shrey

@DianaLease not sure what happened with the rebase here. Can you please suggest how I can fix the DCO check?

Can you amend your last two commits to add the signoff and then force push back to the branch? That should fix it.

Apr 10 '20 19:04 DianaLease

Can you amend your last two commits to add the signoff and then force push back to the branch? That should fix it.

Thanks! It's fixed, please review. @dselman @DianaLease

Apr 10 '20 20:04 sachdeva-shrey