systemc icon indicating copy to clipboard operation
systemc copied to clipboard

Fix macOS PowerPC

Open barracuda156 opened this issue 2 years ago • 6 comments

Fixes: https://github.com/accellera-official/systemc/issues/54

barracuda156 avatar Jun 18 '23 22:06 barracuda156

@lmailletcontoz Could you please take a look at this, and another two PRs below? I have 100% tests passing now on macOS PowerPC.

barracuda156 avatar Jun 18 '23 23:06 barracuda156

@pah: Could you have a look on this PR and the associated issue?

maehne avatar Aug 29 '23 12:08 maehne

PowerPC is only supported using POSIX threads in SystemC 3.0.0

lmailletcontoz avatar Dec 12 '23 16:12 lmailletcontoz

@lmailletcontoz @maehne You still have ppc64 broken though in 3.0.0: there is no define for it in CMakeLists.

barracuda156 avatar Dec 13 '23 10:12 barracuda156

@lmailletcontoz: Please reopen so that maybe @pah can have a second look.

maehne avatar Dec 13 '23 19:12 maehne

@maehne I have rebased to master and dropped QuickThreads addition as unneeded now.

barracuda156 avatar Dec 21 '23 02:12 barracuda156

configuration no longer supported

lmailletcontoz avatar Apr 02 '24 16:04 lmailletcontoz

@lmailletcontoz We are not taking about QuickThreads here anymore.

Macros here have ppc but lack ppc64: https://github.com/accellera-official/systemc/blob/bec101067d808f93bf215031dff6fa9ab7035995/CMakeLists.txt#L335-L336

Macros here have neither: https://github.com/accellera-official/systemc/blob/bec101067d808f93bf215031dff6fa9ab7035995/CMakeLists.txt#L339-L427

barracuda156 avatar Apr 03 '24 03:04 barracuda156

@maehne I think as long as it builds fine de facto, there is no reason to prevent that merely by not having a case in arch/platform detection. That can’t possibly hurt anyone.

barracuda156 avatar Apr 03 '24 10:04 barracuda156

This is merely a cosmetic issue. The library may (or may not) still build on such unsupported configurations. If you want a different target architecture string than macosunknown in such an unsupported scenario, you can set the environment variable SYSTEMC_TARGET_ARCH during the cmake configuration step.

pah avatar Apr 03 '24 18:04 pah