Andrew Calcutt

Results 187 comments of Andrew Calcutt

I tried various zoom levels, like `xvfb-run -a ./mbgl-render -z 6 -y 39.436 -x -101 --style style.json --output out6.png` but I wasn't able to see any clipping. I always assumed...

I've made a application to test this issue here https://github.com/acalcutt/maplibre-label-clipping-test ( Note, this is made to be run in node 10 to be compatible with the mapbox-gl-native release ) Test...

The diff is pretty large between the mapbox last version. My assumption right now is this is related to the mode switch. If I go remove this line (mode: 'tile',)...

I've done a few thing to try and track this down...non successful so far. 1.) I tried setting [viewportPaddingDefault](https://github.com/maplibre/maplibre-gl-native/blob/main/src/mbgl/text/collision_index.cpp#L26) to 1024, like is supposed to happen in tile mode to...

Unfortunately I haven't figured anything else. I haven't had much time to look though since my real job has kept me really busy this month. My last test leads me...

I updated [@acalcutt/[email protected]](https://www.npmjs.com/package/@acalcutt/maplibre-gl-native) to include these [render fixes](https://github.com/maplibre/maplibre-gl-native/pull/351). unfortunately it doesn't look like they fixed the issue here. I was hopeful since the fixes were in the same files... but...

I will say I need to look at these render test in https://github.com/maplibre/maplibre-gl-native/pull/351#issuecomment-1174168866 'render-tests/text-variable-anchor/all-anchors-tile-map-mode' looks like it tests this.

I think I may have figured this out, but I am still testing to be sure. For some reason in platform/node/src/node_map.cpp , the map "withMapMode" was hardcoded to "mbgl::MapMode::Static" and...

It worked! So far I have tested in my [tileserver-gl ](https://github.com/acalcutt/tileserver-gl) and in the [label clipping test ](https://github.com/acalcutt/maplibre-label-clipping-test)above and it seems like it is fixed This should be fixed in...

@wipfli unfortunately I am not aware of how to run the render tests for node, or if there are any.