academico icon indicating copy to clipboard operation
academico copied to clipboard

Add emailing features

Open thdebay opened this issue 3 years ago • 2 comments

  • [ ] Allow to send a custom email to all students in a course
  • [ ] Allow to send a custom email to "members"
  • [ ] Allow to send a custom email to a specific student and/or their registered contacts

thdebay avatar Dec 25 '21 17:12 thdebay

Hey, i am intersted on this issue can i work on it?

henok-tesfu avatar Feb 24 '22 08:02 henok-tesfu

Hello @henok-tesfu and thank you for your interest in the project.

Yes, you're very welcome to work on this feature. I'll assign it to you, please let me know if you need anything!

thdebay avatar Feb 24 '22 19:02 thdebay

Hello @thdebay I am very interested in this issue. May I work on it too?

PatrickMamsery avatar Oct 21 '22 02:10 PatrickMamsery

Hello @PatrickMamsery I didn't have news from @henok-tesfu so I'll assign the issue to you if you want to work on this feature.

Is it clear where to start? Please let me know if you need guidance

thdebay avatar Oct 21 '22 06:10 thdebay

Thanks @thdebay for the opportunity. I am currently working on my local environment setup so that I can run it successfully using Docker. I'll sure notify you in case of anything.

PatrickMamsery avatar Oct 22 '22 04:10 PatrickMamsery

hey is this still open if not I would like to work on it. Did you have any idea how you'd like it done?

wyntonfranklin avatar Dec 27 '22 20:12 wyntonfranklin

Hello @wyntonfranklin, I did not receive PRs from the other developers so I guess the issue is still open. I think a good way to start would be to implement an email feature allowing to write a message to an individual student. You can create a new page with a form to write the email, and the logic to send it to the email registered in the student profile.

Once we have that, it will be easier to implement more complex features such as grouped emailing (for a whole class).

What do you think?

thdebay avatar Dec 27 '22 20:12 thdebay

Sure, that sounds good for a start. I'll get working on it.

wyntonfranklin avatar Dec 27 '22 20:12 wyntonfranklin

Hi @thdebay. I created an email controller page and added the email sending logic. For some reason the redirect after sending the email is not working all the time. (not sure why yet) the branch is here.

What's next?

Screenshot_1_of_email_page

wyntonfranklin avatar Dec 28 '22 21:12 wyntonfranklin

Hello @wyntonfranklin, thank you for your message. It looks great! Can you open a merge request so that I can make a few comments on your code?

The redirect should work, but I'll test it on my local machine and let you know.

I think the next steps would be:

  • to add an "Write an email" button in the student details view, that would redirect to the page you made.
  • to add a similar button in the course "show" view (the list of students) to allow to send the email to the whole class.

What do you think?

thdebay avatar Dec 30 '22 19:12 thdebay

hi @thdebay thanks. I will do the merge request. I can start looking at the other steps as well.

wyntonfranklin avatar Dec 30 '22 20:12 wyntonfranklin

@thdebay, wondering about leadtypes in the students/show.blade.php shows as undefined. might that be an error or did I do something wrong. I usually uncomment the component to interact with this page.

wyntonfranklin avatar Jan 04 '23 23:01 wyntonfranklin

This feature has been removed, I updated the students/show.blade.php code to get rid of the legacy component. Please let me know if it fixes the error!

thdebay avatar Jan 06 '23 16:01 thdebay

it works

wyntonfranklin avatar Jan 08 '23 11:01 wyntonfranklin

Wondering which is the preferred button location for email to student button? Screenshot_email_ui

wyntonfranklin avatar Jan 08 '23 11:01 wyntonfranklin

I think next to the "edit" button is better, but I'm also open to your suggestions. I think it integrates better into the UI. What do you think?

thdebay avatar Jan 10 '23 19:01 thdebay

I agree. I left it next to the edit button. Initially I didn't quite understand how to place a button there so placing at the top was simplest.

wyntonfranklin avatar Jan 10 '23 21:01 wyntonfranklin

Fixed in #312

thdebay avatar Jan 11 '23 19:01 thdebay