Andrew Clayton

Results 552 comments of Andrew Clayton

So, there are two checks here in src/nxt_php_sapi.c::nxt_php_set_target() (and this only applies to the 'script' option and not 'index') 1) Does the full path to the script exist? 2) Is...

@rbro You could try this patch ```diff diff --git a/src/nxt_php_sapi.c b/src/nxt_php_sapi.c index 68ef07eb..373b0fb4 100644 --- a/src/nxt_php_sapi.c +++ b/src/nxt_php_sapi.c @@ -583,13 +583,6 @@ nxt_php_set_target(nxt_task_t *task, nxt_php_target_t *target, target->script_filename.length = nxt_strlen(p); target->script_filename.start...

I will take a look in due course. I don't see any reason not to allow it.

@g105b You could try giving this somewhat simple patch a spin. It simply lets you specify the "script" as an absolute path. ```diff diff --git a/src/nxt_php_sapi.c b/src/nxt_php_sapi.c index 42fdbc68..260350b0 100644...

A couple of general comments 1) Could you rebase against current master to get rid of the merge commit for easier review. 2) Could you provide meaningful commit messages/summaries? Otherwise...

FWIW, I agree with @hongzhidao, we should start with the simple fix. Then we can look at dealing with any real performance or istylistic issues etc...

Can do, haven't tried yet, but I think the mapping would happen in the ```nxt_router_http_conf[]``` array in _src/nxt_router.c_, e.g it would become ```C { nxt_string("max_header_size"), NXT_CONF_MAP_SIZE, offsetof(nxt_socket_conf_t, large_header_buffer_size), }, ```...

There's less than half a dozen references to ``` large_header_buffer_size``` so it's not a big deal to change.

@hongzhidao Hi Zhidao, if you review this and use the above 'Compare' button, ignore the changes to the first couple of files, they are from a different commit and not...