Andrew Clayton

Results 552 comments of Andrew Clayton

Hi @Pavlusha311245 Thanks for the PR! OK, first things first, this is going to need a commit message. What is this commit introducing and why do we want/need it. In...

> @ac000 Do you need a commit message like this? Hi. > ``` > Add unit section to status endpoint > > Added unit section to /status endpoint. Unit section...

Thanks for that, quick couple of questions. ```json "unit": { "version": "1.32.0", "load_time": "2024-01-25T13:24:08.000Z", "generation": 0 }, ``` Is ```load_time``` when unit was started or last configured? What does ```generation```...

If you have it split out locally, you can force push it here with ```git push -f ...```

After you split the changelog changes into their own commit, you should then have two commits for this PR, at which point you can force push them to your feature/unit_about_section...

> > Thanks for that, quick couple of questions. > > ```json > > "unit": { > > "version": "1.32.0", > > "load_time": "2024-01-25T13:24:08.000Z", > > "generation": 0 > >...

> I can add it. Ask me if you know how to name it better. Do I need add `start_time`? My current suggestion is 'load_time' -> 'last_configured' but maybe others...

Hi @hongzhidao Can a `nxt_time_string_t` store an arbitrary time? It's not immediately obvious to me as the handler function seems to basically take a struct timespec and struct tm representing...

@hongzhidao It's a convoluted interface, but I see how it would work now. However I think it could end up doing quite a lot of work at start up that...

@hongzhidao > I'd suggest you change `nxt_http_var_time_local()` to meet the new > string format and you can test it with access log. Are you suggesting to change the format of...