Andrew Clayton
Andrew Clayton
This patch implements (2) above... ```diff diff --git ./src/otel/src/lib.rs ./src/otel/src/lib.rs index eb1a7bad..caf28d82 100644 --- ./src/otel/src/lib.rs +++ ./src/otel/src/lib.rs @@ -7,7 +7,7 @@ use opentelemetry_otlp::Protocol; use opentelemetry_otlp::WithExportConfig; use opentelemetry_sdk::trace::{Config, BatchConfigBuilder, Sampler}; use...
Hmm, I swear I didn't get the camel case warning after I added the #allow directive, but seems I actually need this small patch on top of the latest commits......
Small indentation issue in src/nxt_otel.c ```diff diff --git ./src/nxt_otel.c ./src/nxt_otel.c index 7ab05111..eea12e24 100644 --- ./src/nxt_otel.c +++ ./src/nxt_otel.c @@ -311,7 +311,7 @@ nxt_otel_test_and_call_state(nxt_task_t *task, nxt_http_request_t *r) void nxt_otel_request_error_path(nxt_task_t *task, nxt_http_request_t *r)...
Other than the above minor issues and the commit tags/trailers needing [tweaked](https://github.com/nginx/unit/pull/1463#pullrequestreview-2383446748), it's looking about ready to merge... One, more, operational question I have is if you are getting data...
> re: commit trailers, out of curiosity it looks like we've only used `Co-developed-by` 13 times (4 crediting Alex, 4 crediting Right and never Co-authored-by, we could have gone with...
> I _think_ one possible place we could do that is within `nxt_router_process_http_request`. We have the request (and therefore the attached otel struct), and `nxt_http_action_t`, which looks like it holds...
> When not using unit, Does this mean when Unit is _not_ running? > However, when using unit, Does this mean when Unit _is_ running? > the same operation uses...
I see various permission denied errors, I wonder if they need to run as root there... we do run the tests as root in the ci and they all pass...
> They seem to succeed running as sudo, yes. > > Also, with `sudo sysctl kernel.apparmor_restrict_unprivileged_userns=0`, and running unprivileged, they also succeed, except for php: > > ``` Yeah, Ubuntu......
Can't reproduce here... ```json { "listeners": { "[::]:80": { "pass": "routes" }, "[::]:443": { "pass": "routes", "tls": { "certificate": "bundle" } } }, "routes": [ { "action": { "share": "/srv/unit$uri"...