Andrew Clayton
Andrew Clayton
PR [opened](https://github.com/nginx/clang-ast/pull/2).
- Switch to the unit branch of nginx/clang-ast now that the needed fix has been merged, thanks to @thresheek ``` $ git range-diff 83557d99...3304aaf4 1: 83557d99 ! 1: 3304aaf4 ci:...
> Should test be included in this check? it's mostly Python code, and I am not aware of any difference it could make in the output Unit binary The pytests...
> Can you clarify the desired outcome to this PR? This was a check that used to run on our buildbot infrastructure, this is simply running it here now. >...
- Run this over the C tests also - We need to use -add-plugin in order to have the object files created - Add a fix for an issue it...
Need to actually configure and build the tests! ``` $ git range-diff dad4727a...107055ed 1: dad4727a ! 1: 107055ed ci: Add a clang-ast workflow @@ .github/workflows/clang-ast.yaml (new) + make + +...
- Set the clang-ast plugin arguments at configure time ``` $ git range-diff 107055e...f04bc68d 1: 107055ed ! 1: f04bc68d ci: Add a clang-ast workflow @@ .github/workflows/clang-ast.yaml (new) + make +...
- Add coverage for the language modules (except go and wasm-wasi-component, neither of which are using clang) ``` $ git range-diff f04bc68d...9fcf6021 1: f04bc68d ! 1: 9fcf6021 ci: Add a...
- Drop the src/test fix, that will go in via https://github.com/nginx/unit/pull/1481 ``` $ git range-diff 9fcf6021...c9181663 1: cfb52003 < -: -------- src/test: Fix missing parameter to nxt_log_alert() in nxt_base64_test() 2:...
Rebase with master ``` $ git range-diff c9181663...1e345b34 -: -------- > 1: 85f21b7c Use nxt_nitems() instead of sizeof() for strings (arrays) -: -------- > 2: 9f6f4866 src/test: Fix missing parameter...