Andrew Clayton

Results 203 comments of Andrew Clayton

This has been discussed [here](https://github.com/nginx/unit/issues/915), and my feeling on it is [here](https://github.com/nginx/unit/issues/915).

``` fs: Correctly handle "/" in nxt_fs_mkdir_parent() The previous code attempted to mkdir(""), that is an empty string. Since "/" necessarily exists, just goto out_free. ``` Only _if_ they attempted...

> Actually, `--pid /unit.pid` would also result in that, since we get the dirname of it. These days, people often place stuff in the root of docker containers (I don't...

The prefixes are just supposed to be general topics/area's of the code, so I wouldn't put a function name in there...

> The Christmas tree variable ordering is documented here: > Yeah, seen it before, we don't strictly follow that anyway, e.g pointer alignment. Too many idiosyncrasies... > I like the...

Please see my previous comment about prefixes...

My intention for the prefixes/topics is to do it this way ``` thing: ... ``` ``` thing/subthing: ... ``` or ``` thing: subthing: ... ``` (Though those are perhaps not...

Overall I think these changes look good. The last one (using octal instead of the symbolic constants) _may_ be controversial and I'd like to have at least @thresheek 's `Acked-by:`...

Let's just close this now. A fix was merged for the issue that inspired this PR...

Two new settings (undocumented and subject to change) have been merged. - large_header_buffer_size In simple terms, determines the maximum size of any single header _value_ (including the request line). Defaults...