Andrew Clayton

Results 203 comments of Andrew Clayton

Ok, so that's not so simple. This will also break with "wasm-wasi-http" as a module name. I can't see a clean way of solving this without introducing a new MODULE=...

```diff diff --git a/pkg/docker/Makefile b/pkg/docker/Makefile index 237228a9..366e2a4e 100644 --- a/pkg/docker/Makefile +++ b/pkg/docker/Makefile @@ -6,10 +6,12 @@ include ../shasum.mak DEFAULT_VERSION := $(NXT_VERSION) VERSION ?= $(DEFAULT_VERSION) PATCHLEVEL ?= 1 +MODULE = +...

As it stands it's fundamentally flawed, but there is a better way to fix it without introducing a MODULE variable...

Looking like a MODULE variable is the only sane way to do this...

It would need some extra work as it likely breaks some other targets.

There seems to be another issue with this thing. Doing a `make clean` removes a bunch of dockerfiles which are tracked by git... this seems wrong ``` $ git status...

Generally speaking, things which are generated artefacts should not be tracked by version control.

Actually the above patch does look like the best fix for now...

This is about the best I can come up with while fixing it for this and _not_ breaking it for the other targets. NOTE: This introduces a new target, `gen-`,...

Yeah, Unit will want to create a few file-system objects. The obvious thing I can think of is to start unit and point the various things it wants to create...