Andrew Clayton

Results 203 comments of Andrew Clayton

I assume your memory_limit in php.ini is set a good deal larger than the files that are failing to download? We really need to find the cause of the SIGBUS's,...

OK, so PHP seems to handle exceeding its `memory_limit` gracefully...

> It does seem to work fine - however I'm reluctant to that change since it's a mess from users' POV: why would I choose to use `make gen-` targets...

Looking at the log it seems ``` php-unit: /usr/local/bin/docker-entrypoint.sh: Applying configuration /docker-entrypoint.d/nginx-unit.json php-unit: 2022/11/23 16:50:03 [info] 21#21 "benchmark" prototype started ``` Unit was started with some initial config. ``` php-unit:...

@micaelmalta (and anyone else) feel free to try the patch here https://github.com/nginx/unit/issues/815#issuecomment-1396132323

I have pushed a [branch](https://github.com/ac000/unit/tree/asyncio) that contains the above fix, if that facilitates easier testing.

I mean the only errors I'm seeing for php-unit are a bunch of [socket connection errors ](https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/6079079817/job/16491119686#step:9:6415) ``` Verifying test db for php-unit caused an exception: HTTPConnectionPool(host='tfb-server', port=8080): Max retries...

> I think the problem is that Unit needs too much time to initialize all the forks(processes|workers). Are you saying that Unit itself is failing somehow due to trying to...

Can we block the CI runs if say anything under _.github/_ changes? As that seems to be where the concern lies... Maybe the runners themselves could check? I believe you...