dist-clang icon indicating copy to clipboard operation
dist-clang copied to clipboard

Published 20 hours ago • verified publisher icon abyss7

Issue 29, check for bad client version

Open dreamer-dead opened this issue 9 years ago • 2 comments

Hi!

Here is my initial version of client version validation (#29), so we can discuss this approach. Constant 100 for version is a sample only. Should we expose that minimal version value to C++ code and keep it sync with the default value in proto file? Please, take a look.

dreamer-dead avatar Nov 10 '15 14:11 dreamer-dead

Added a new field in Absorber config with tests. Check for minimum version is quite straightforward, and we can add a max_version to check version in some interval.

dreamer-dead avatar Nov 11 '15 16:11 dreamer-dead

Done with review.

abyss7 avatar Nov 11 '15 19:11 abyss7