Amazon-SP-API-CSharp icon indicating copy to clipboard operation
Amazon-SP-API-CSharp copied to clipboard

The entire app changes to invariant culture and currency symbols change to ¤

Open Tajanos opened this issue 1 year ago • 1 comments

#673 introduces an application-wide bug. Since this is not a breaking change but an optional parameter, if someone doesn't change their existing code to provide cultureInfo, the entire thread that called the library will have its culture changed to invariant. This might mean, for example, that all UI screens will lose their currency formatting and the numbers will look like this: ¤123.00 instead of $123.00 or €123,00

public AmazonConnection(AmazonCredential Credentials, string RefNumber = null, CultureInfo? cultureInfo = null) { Authenticate(Credentials); this.RefNumber = RefNumber; Thread.CurrentThread.CurrentCulture = cultureInfo ?? CultureInfo.InvariantCulture; }

Tajanos avatar Jan 26 '24 23:01 Tajanos

Changes InvariantCulture to default - CurrentCulture: #708 this should be fix the issue

kevinvenclovas avatar Jan 29 '24 06:01 kevinvenclovas