Amazon-SP-API-CSharp icon indicating copy to clipboard operation
Amazon-SP-API-CSharp copied to clipboard

Get rid of unneccessary custom List types

Open janek49 opened this issue 2 years ago • 0 comments

Why does this library use so many custom types that just extend List ?

For example:

namespace FikaAmazonAPI.Utils { public class MarketplaceIds : List<string> { } }

Used in ParameterCreateReportSpecification:

public MarketplaceIds marketplaceIds { get; set; }

Why don't just use a public List<string> marketplaceIds { get; set; } ?

This style makes it really annoying to use short-hand initialization of objects (for example with LINQ data), as you need to create a local variable for the custom list, fill it with data and then pass it to the object, instead of just doing ToList()

janek49 avatar Nov 23 '23 09:11 janek49