easyloggingpp icon indicating copy to clipboard operation
easyloggingpp copied to clipboard

conan option for default logfile inverse

Open CrazyDaisyRecords opened this issue 3 years ago • 1 comments
trafficstars

Issue

The conan option "enable_default_logfile" behaves in a inverse way. The conanfile of the package version 9.97.0 handles the option as followed:

if self.options.enable_default_logfile:
            self.cpp_info.defines.append("ELPP_NO_DEFAULT_LOG_FILE")

Proposal

This option shall be handled inverse.

if not self.options.enable_default_logfile:
            self.cpp_info.defines.append("ELPP_NO_DEFAULT_LOG_FILE")

CrazyDaisyRecords avatar Jun 27 '22 08:06 CrazyDaisyRecords

Not sure this is project is maintained but in CCI there's a PR for something similar to this https://github.com/conan-io/conan-center-index/pull/14332

It would be amazing is the CCI build script could be brought back here to this project so everyone could benefit from it.

prince-chrismc avatar Dec 01 '22 22:12 prince-chrismc