Adolfo Builes

Results 58 comments of Adolfo Builes

@linstula is something around here https://github.com/dockyard/ember-cli-bootstrap/blob/master/vendor/ember-addons.bs_for_ember/dist/js/bs-core.max.js#L418 Edit: If I uncomment the following it works https://github.com/dockyard/ember-cli-bootstrap/blob/master/vendor/ember-addons.bs_for_ember/dist/js/bs-core.max.js#L420

@linstula The root of the problem is the following `Ember.Handlebars.compile` in https://github.com/dockyard/ember-cli-bootstrap/blob/master/vendor/ember-addons.bs_for_ember/dist/js/bs-core.max.js#L420 When running `ember build --production` `ember-cli` builds with `handlebars.runtime.js` which doesn't have `.compile`.

More info https://github.com/ember-addons/bootstrap-for-ember/issues/87

Hi! I forgot a couple of things. If you support [SEP0029 memo required check](https://github.com/stellar/stellar-protocol/blob/8d2c0477578c53e685ca402084b4a9bf208a186a/ecosystem/sep-0029.md), then it needs to be updated to support fee bump transactions. You can check pull request...

As @overcat and @tamirms pointed out [here](https://github.com/stellar/js-stellar-sdk/pull/535/files#r416675569), we shoud skip the SEP0029 check if the destination is an `M..` address since `M..` addresses encode a memo within them.

## Action needed: Revert support of M-strkeys from all SDKs TL;DR: we need to remove support for M-strkeys ([SEP23](https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0023.md)) from all the SDKs. If the SDK you are maintaining still...

@t1mmen thanks! there were some recent changes to addons, I'll check this out :)

@jdowd thanks! yes, we have a new patter now, I'll rewrite to match this :)

Thanks! this is actually intentional, if you continue going through I'll show you later how to solve that issue. This has been mentioned by different people, so I will add...