Adolfo Builes
Adolfo Builes
@msfeldstein we have this validation in place already via TypeScript. The downside is that it won't be done if you are using plain JS which is probably your scenario. While...
> I'm not sure I agree with that, we shouldn't prescribe tooling to our users to that degree. If we do we should call this ts-stellar-sdk You are right. I'm...
I transferred this issue to js-stellar-base which is where the underlying issue exists. After looking at the code, we do validate the arguments, however, we ignore extra arguments in options,...
@charlie-wasp sure thing, please go ahead! Btw, I dropped the ball in the ts migration, maybe we should revisit it in a couple of weeks.
@Akuukis sounds like a good plan! Do you want to have a stab at it? Thanks!
@Akuukis @charlie-wasp I've kicked off gears for this, I'm pinging you since you both show interests on helping with this :). I created a branch called `typescript` where we can...
@charlie-wasp hey! Better late than never -- we still got some work to do. I'm happy if you can help on this, we have a branch with the current changes...
@MisterTicot btw, I have a POC here https://github.com/abuiles/json-xdr which you could play with, you can use that library to convert between JSON and XDR. See this file for examples on...
@kiwiupover I don't think so. Want to submit a PR ? :)
@SamvelRaja can you please rebase and I'll merge it after that :)