confd icon indicating copy to clipboard operation
confd copied to clipboard

Vault: Nested values in vault_v2 is not being read.

Open jbsmith7741 opened this issue 1 year ago • 2 comments

Nested Values in vault_v2 are not being evaluated recursively. Comparing output of the integration tests for vault-v1 and vault-v2 for the nested-test, we see that the server sections are not being populated in vault-v2.

vault-v1

upstream app {
    server {"app1":"10.0.1.10:8080"};
    server {"app2":"10.0.1.11:8080"};
}

server {
    server_name  www.example.com;
    location / {
        proxy_pass        http://app;
        proxy_redirect    off;
        proxy_set_header  Host             $host;
        proxy_set_header  X-Real-IP        $remote_addr;
        proxy_set_header  X-Forwarded-For  $proxy_add_x_forwarded_for;
   }
}

vault-v2

upstream app {
}

server {
    server_name  www.example.com;
    location / {
        proxy_pass        http://app;
        proxy_redirect    off;
        proxy_set_header  Host             $host;
        proxy_set_header  X-Real-IP        $remote_addr;
        proxy_set_header  X-Forwarded-For  $proxy_add_x_forwarded_for;
   }
}

jbsmith7741 avatar May 10 '24 20:05 jbsmith7741

@jbsmith7741 can you provide more details on the environment, versions, etc where this issue is happening?

The automated integration tests running via Github Actions don't seem to be catching the same issue and I'm not currently able to replicate it locally.

abtreece avatar May 16 '24 15:05 abtreece

@jbsmith7741 can you provide more details on the environment, versions, etc where this issue is happening?

The automated integration tests running via Github Actions don't seem to be catching the same issue and I'm not currently able to replicate it locally.

Disregard, I see it now... 🤔

Would also help if there was actually a check for that scenario in the integration tests... 🤦🏻‍♂️

abtreece avatar May 16 '24 15:05 abtreece

@jbsmith7741 I believe this issue has been fixed. Do note the breaking changes introduced with the refactor...

abtreece avatar Sep 23 '24 20:09 abtreece