rewind icon indicating copy to clipboard operation
rewind copied to clipboard

Miss detection (detecting too many)

Open abstrakt8 opened this issue 4 years ago • 3 comments

Based on a few reports we detect a few more misses than osu!stable when the cursor hits the edge of the hitcircle (Example) However, this also happens in osu!lazer:

https://youtu.be/B8PN7jDgUKg?t=121 https://youtu.be/ErcwwktKUs4?t=113

Submitted replays: https://drive.google.com/drive/folders/1KMYxGrG3sWK-I3r-ZuRRln65Vg5wLE5s?usp=sharing

abstrakt8 avatar Sep 12 '21 08:09 abstrakt8

Haven't investigated but sounds like this https://github.com/McKay42/McOsu/blob/303a99e01246d7533fff9d2f79e7aaa5fc7861bb/src/App/Osu/OsuGameRules.h#L339-L342

PercyDan54 avatar Dec 05 '21 02:12 PercyDan54

Another thing: Though I also don't have stable source, but it's possible to take a look at it by decompiling osu!fx via dnSpy (supports editing & debugging) or ILSpy

Kinda illegal but yeah

PercyDan54 avatar Dec 05 '21 02:12 PercyDan54

Haven't investigated but sounds like this https://github.com/McKay42/McOsu/blob/303a99e01246d7533fff9d2f79e7aaa5fc7861bb/src/App/Osu/OsuGameRules.h#L339-L342

Thanks that might actually be it - seems to be used in other osu! projects as well. I will include that fix after I created the testing framework.

abstrakt8 avatar Dec 05 '21 10:12 abstrakt8